Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to embedart using an image URL [small PR] #4719

Merged
merged 32 commits into from
Apr 21, 2023
Merged

Added option to embedart using an image URL [small PR] #4719

merged 32 commits into from
Apr 21, 2023

Commits on Mar 18, 2023

  1. Add option to import using URL

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    f051d67 View commit details
    Browse the repository at this point in the history

  2. Update embedart.py

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    feeeb40 View commit details
    Browse the repository at this point in the history

  3. Update embedart.py

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    4dd1654 View commit details
    Browse the repository at this point in the history

  4. Update embedart.py

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    81835b0 View commit details
    Browse the repository at this point in the history

  5. Update embedart.py

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    64c2ae1 View commit details
    Browse the repository at this point in the history

  6. Update embedart.py

    @arsaboo
    arsaboo committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    59d5d23 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Move import inside the function

    @arsaboo
    arsaboo committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    2d942ce View commit details
    Browse the repository at this point in the history

  2. Update parser options

    @arsaboo
    arsaboo committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    2060e04 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Add additional error handling

    @arsaboo
    arsaboo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    2e2a3bf View commit details
    Browse the repository at this point in the history

  2. More error handling

    @arsaboo
    arsaboo committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    a4b4df8 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Update documents and add changelog entry

    @arsaboo
    arsaboo committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    6626b76 View commit details
    Browse the repository at this point in the history

  2. Add FilesystemError handling

    @arsaboo
    arsaboo committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2fcdb8c View commit details
    Browse the repository at this point in the history

  3. Raise OSError

    @arsaboo
    arsaboo committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    3b39a4f View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. Address review comments

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    93f4068 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into embedart_url

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    23b42e8 View commit details
    Browse the repository at this point in the history

  3. Remove unused imports

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    b3008b7 View commit details
    Browse the repository at this point in the history

  4. Change image format to PNG

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    9c3f4a4 View commit details
    Browse the repository at this point in the history

  5. Add more error handling for the img.save function

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    99ca3e9 View commit details
    Browse the repository at this point in the history

  6. Move away from PIL and use mimetypes instead

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    34a4e7b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into embedart_url

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    4d39b40 View commit details
    Browse the repository at this point in the history

  8. Change indentation

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    8357617 View commit details
    Browse the repository at this point in the history

  9. Remove temporary logging

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    3a1e4bd View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'upstream/master' into embedart_url

    @arsaboo
    arsaboo committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    023f3d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Use temp folder instead of cwd

    @arsaboo
    arsaboo committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1e3fee8 View commit details
    Browse the repository at this point in the history

  2. Address comments

    @arsaboo
    arsaboo committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0492f1f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Remove logging

    @arsaboo
    arsaboo committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    bb2ce02 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Add test for embedart -u fetching jpeg from url

    @JOJ0
    JOJ0 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3dd32c9 View commit details
    Browse the repository at this point in the history

  2. Updated language

    @arsaboo
    arsaboo committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d48eab9 View commit details
    Browse the repository at this point in the history

  3. Add test for png image

    @arsaboo
    arsaboo committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    919f326 View commit details
    Browse the repository at this point in the history

  4. Add test for invalid URL

    @arsaboo
    arsaboo committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    47cb11b View commit details
    Browse the repository at this point in the history

  5. Fix embedart -u test names 

    and shorten second and third test a little by providing -y cli flag. Enough to
test with interactive input once. Move all 3 tests to the very bottom of the
test class.
    @JOJ0
    JOJ0 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f3d4929 View commit details
    Browse the repository at this point in the history

  6. Fix text/html file ending in embedart -u test 

    Makes it more clear what we are doing.
    @JOJ0
    JOJ0 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    56adba7 View commit details
    Browse the repository at this point in the history