Refactor Candidate class in fetchart.py to improve resizing logic #5152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation and resizing logic
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
from
6ccf83b
to
66b459b
Compare
- generic method to check if operation was performed - add test of deinterlace operation - add test for multiple operations performed if required (fails on master)
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
from
98ddce0
to
6a27a8d
Compare
Closed
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
from
eb05d15
to
dc0b46d
Compare
This comment has been minimized.
This comment has been minimized.
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
2 times, most recently
from
0132bfa
to
5a80de9
Compare
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
from
5a80de9
to
f95cfc2
Compare
Dr-Blank
force-pushed
the
bug-fetchart-resize-logic-fix
branch
from
f95cfc2
to
57677bd
Compare
|
fixed the error with Mock Objects in previous CI runs with 57677bd should be good now |
Serene-Arc
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5151
keep resizing until all validations have passed.
Candidate._validategives priority to reformatting before downsizing since in case of PNG it downsizes by converting to JPEG and if still does not match the size requirements it still remains to perform since first performing downsizing does nothing and is later skipped to avoid getting stuck in an infinite loop.To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)