fix(import): don't throw away album flexible fields #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkChaos
commented
Aug 16, 2024
ThinkChaos
force-pushed
the
fix/save-album-flexible-fields
branch
from
c6dfe1e
to
dc61ef0
Compare
snejus
requested changes
Aug 25, 2024
ThinkChaos
force-pushed
the
fix/save-album-flexible-fields
branch
2 times, most recently
from
aba5877
to
08bcbd4
Compare
snejus
reviewed
Aug 26, 2024
ThinkChaos
force-pushed
the
fix/save-album-flexible-fields
branch
from
08bcbd4
to
c131d5d
Compare
As noted by 5bf4e3d, MusicBrainz external IDs (`*_album_id`) were only saved for items and not albums. This commit addresses that by copying `AlbumInfo` fields to the `Album`, i.e. what's saved in the DB. This is similar to how `TrackInfo` fields are copied to `Item` instances except the copying is done at a different time since we only get an `Album` much later in the import flow.
Co-authored-by: Šarūnas Nejus <snejus@protonmail.com>
ThinkChaos
force-pushed
the
fix/save-album-flexible-fields
branch
from
c131d5d
to
bf32d9a
Compare
snejus
approved these changes
Aug 26, 2024
|
Thanks for the review! |
|
@ThinkChaos thank you very much for this PR! I love the refactoring you did to the *_id fetching code! So much cleaner and shorter now! Also many thanks to @snejus for taking over with a review, much appreciated! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe this fixes #4785, but I might be misunderstanding the description and it might already be fixed.
Tagging @JOJ0 since they created both the bug linked above, and 5bf4e3d which mentions it.
To Do
Documentation. (If you've added a new command-line flag, for example, find the appropriate page underdocs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)