Include curses in macOS support package #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
approved these changes
Mar 6, 2021
There was a problem hiding this comment.
👍 I've updated the patch so that it's compatible with the embedded executable changes from beeware/briefcase#525; otherwise, thanks for the patch!
|
Seems like curses was removed again from the Python 3.10 macOS build. Was this intentional? |
|
Hm, I think this was a side effect of 7b35fc5. |
|
Oh drat. No, it wasn't intentional; I got overzealous with some refactoring. We (by which I mean, probably I) really do need to work out how to do an automated release test on these builds... |
|
This may be a stupid question, but why did excluding any of the other .so files not cause any problems? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in beeware/briefcase#516, this PR includes curses in the support package.
MacOS already comes with ncurses bundled so we only need to include Python package and extension module, increasing the size of the support package by roughly 0.3 MB.
PR Checklist: