Fixup improve download changes #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tar's -f option expects a single archive-file, therefore the name of the first prerequisite ($^) of download related targets should be passed instead of the names of all the prerequisites ($^).
so the name of the first prerequisite ($<) can be used as an argument to tar's -f option.
and use name of first prerequisite as an argument to tar's -f option. This is a follow-up on PR beeware#155.
freakboy3742
approved these changes
Aug 17, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging PR #155, @freakboy3742, much appreciated.
It seems that PR was missing some changes that slipped my attention and broke the
devbranch; apologies for that.This PR adds the missing changes (see commit fac33f9) and corrects (commit 9514d46) and improves (commit 6d1511b) the downloads targets further.
I have tested these changes successfully before issue this PR and I hope you agree with the proposed changes.
PR Checklist: