Use correct PATH to find macOS Python in Makefile #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When configuring the iOS/watchOS/tvOS Python, the PATH is prepended such that the (host) macOS Python x86_64 binary can be found. But the `$(PROJECT_DIR)/build/macOS/python/bin` is not there yet. It is created only later in the target `dist/Python-$(PYTHON_VER)-$1-support.b$(BUILD_NUMBER).tar.gz`. Until then, the macOS Python is only available in the `$(PROJECT_DIR)/$(PYTHON_DIR-macOS)/dist/` dir. Therefore, this is the correct dir to be used in the PATH var.
freakboy3742
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the iOS/watchOS/tvOS Python, the PATH is prepended
such that the (host) macOS Python x86_64 binary can be found. But the
$(PROJECT_DIR)/build/macOS/python/binis not there yet. It is createdonly later in the target
dist/Python-$(PYTHON_VER)-$1-support.b$(BUILD_NUMBER).tar.gz.Until then, the macOS Python is only available in the
$(PROJECT_DIR)/$(PYTHON_DIR-macOS)/dist/dir. Therefore, this is thecorrect dir to be used in the PATH var. At least I do assume this to be the case.
I think (but have not checked) this could apply to the other version branches, too.
Note: I noticed this by using the 3.6 branch and I don't have a python3.6 on PATH on my system. If you indeed have some python3.6 on your PATH, then you won't notice and silently that external python3.6 will be used for building iOS/watchOS/tvOS python.