Dockerfile: removed supervisor, added S6 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanlatten
force-pushed
the
feature-s6
branch
2 times, most recently
from
e6a1c1c to
99dd966
Compare
bryanlatten
force-pushed
the
feature-s6
branch
6 times, most recently
from
e16050e to
4a59a8d
Compare
|
This is bonkers! (A good kind) |
|
✅ |
|
S6 looks like it's worth trying! |
|
👍 but we should test this for a bit! |
bryanlatten
force-pushed
the
feature-s6
branch
2 times, most recently
from
29ef98a to
1e0b41e
Compare
|
👍 I def need to learn more about what s6 is doing but this looks good. |
|
👍 This is really great -- a muuuuch better fit for containers than runit/supervisord. |
Do not merge until workerized processes are converted from supervisor behavior
bryanlatten
pushed a commit
that referenced
this pull request
Mar 18, 2016
Dockerfile: removed supervisor, added S6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S6 is much lighter than supervisor (1MB vs. 70MB, static compilation vs. python dependency) and supports cleaner startup processes, such as preemptive
cont-init.dandfix-attrs.dscript support. It also boots a container's process tree in under100ms(from their docs, but feels even faster in real life compared to supervisor). Supervisor (and runit) are not actually designed as PID 1 init replacements.