Dockerfile: changing to non-privileged port #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:16.04 | |||
| FROM ubuntu:14.04 | |||
There was a problem hiding this comment.
rolling back, wasn't helpful downstream
|
👍 |
| echo '[run] enabling web server' | ||
|
|
||
| # Unfortunately, until Dockerhub supports this operation...it has to be done here | ||
| setcap cap_net_bind_service=+ep /usr/sbin/nginx |
There was a problem hiding this comment.
dockerhub couldn't run this command, neither can docker 1.11 by default
There was a problem hiding this comment.
Is this just an option that needs to run via root ?
There was a problem hiding this comment.
its something that allows you to run on privileged port without root on nginx
|
This might require updates to consumers using tugboat, but worth checking just to make sure it grabs this exposed port correctly |
|
@Attamusc no tugboat change needed. it picks up everything! |
|
woohoo! |
|
As long as roll out to existing containers is done carefully and there is no fear of this being auto rolled out. w/ this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.