Update woff mime-type and define new one for woff2. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerikson
commented
Oct 9, 2017
| # Add again with newer mime-type | ||
| sed -i "s/}/\n font\/woff woff;\n&/" /etc/nginx/mime.types && \ | ||
| # Also add mime-type for WOFF2 | ||
| sed -i "s/}/\n font\/woff2 woff2;\n&/g" /etc/nginx/mime.types |
There was a problem hiding this comment.
I figured more lines that did specific things was more legible and simpler to understand, a single-line version is probably possible here if we think that's a better approach.
There was a problem hiding this comment.
@eerikson could you add the link to the nginx ticket to track as a comment before your implementation?
There was a problem hiding this comment.
Ah of course, thanks for reminding me! Added.
eerikson
force-pushed
the
AddNewFontMimeTypes
branch
from
ff7bbd2 to
f92d6d9
Compare
mannytoledo
reviewed
Oct 9, 2017
Dockerfile
Outdated
| # Remove older WOFF mime-type | ||
| sed -i "/application\/font-woff/d" /etc/nginx/mime.types && \ | ||
| # Add again with newer mime-type | ||
| sed -i "s/}/\n font\/woff woff;\n&/" /etc/nginx/mime.types && \ |
There was a problem hiding this comment.
Nitpick but can we remove the second newline (\n) here, the one after the semicolon. The result will have both fonts together at the end of the file as opposed to 1 line apart.
i.e
font/woff woff;
font/woff2 woff2;
}
instead of
font/woff woff;
font/woff2 woff2;
}
|
@eerikson One comment but very nice |
fixes adobe-community/issues#19309
eerikson
force-pushed
the
AddNewFontMimeTypes
branch
from
f92d6d9 to
f4364d7
Compare
mannytoledo
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes adobe-community/issues#19309