-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use collect output in filter/add_column and optional report #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvfe
added a commit
that referenced
this pull request
Jun 27, 2023
* master: fix: Change create_report back to high_memory refactor: Use collect output in filter/add_column and optional report (#139) refactor: Increase default reqs for ppanggolin and create_report (#137) feat: Check sample ID validity with Annotation input check (#136) feat: Add annotation tools param (#134) docs: Add new ARETE logo (#135) feat: Add param to skip the pan/phylo subwf (#132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Integrate concat and filter matches in one process
refactor: Change image for filter_matches
fix: Change output module name
fix: Correct string interpolation
refactor: Change add column to work with collected output
fix: Change sed regex
fix: Change sed regex
refactor: Make sed expression case-insensitive
Closes Change add_column/filter_matches processes to run with collected output #138