Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-0007 - Numeric Annotations #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ncatlett
Copy link
Contributor

@ncatlett ncatlett commented Jul 24, 2018

Numeric annotations - BEP7

closes #15

Numeric annotations

closes #15
@cthoyt cthoyt changed the title Create BEP-0007.md Create BEP-0007.md - Numeric annotations Oct 14, 2018
@cthoyt
Copy link
Contributor

cthoyt commented Oct 15, 2018

Does it make sense to associate units separately from the values that are being measured? I had written BEL like this before:

SET Citation = {"PubMed", "23484434"}

############
# Figure 4 #
############

# Disambiguation: TAGI is short for "tau aggregation inhibitors"
SET Evidence = "Redox cycling of methylene blue and TAGI potencies. Upper 
panel (black): Reduced leuco form 2 and structural overlap with inactive 
phenothiazines 3, 4, and 5.  Lower panel (blue): Structural overlap between 
oxidized form 1 and azure A (6), reduced anthraquinone, 8, and 9, showing 
the extended π-conjugated system (ND: not determined)."
SET Page = "D"
SET Figure = "4"

# Disambiguation: CHEBI:22580 label "anthraquinone"
# Disambiguation: HBP00006 label "Tau aggregates"
SET ArticleCompoundNumber = "7"
SET MeasurementType = "IC50"
SET MeasurementUnits = "μM"
SET MeasurementRelation = "~"
SET MeasurementValue = "2"
a(CHEBI:"22580") -| a(HBP:HBP00006)
UNSET {ArticleCompoundNumber, MeasurementType, MeasurementUnits, \
   MeasurementRelation, MeasurementValue}

Or what about when there's a numerical range, like in:

# Disambiguation: CHEBI:6872 label "methylene blue"
# Disambiguation: HBP00006 label "Tau aggregates"
SET ArticleCompoundNumber = "1"
SET MeasurementType = "IC50"
SET MeasurementUnits = "μM"
SET MeasurementRelation = "="
SET MeasurementRangeLower = "1.9"
SET MeasurementRangeUpper = "31"
a(CHEBI:"6872") -| a(HBP:HBP00006)

UNSET {ArticleCompoundNumber, MeasurementType, MeasurementUnits, \
   MeasurementRelation, MeasurementRangeLower, MeasurementRangeUpper}

@cthoyt cthoyt changed the title Create BEP-0007.md - Numeric annotations BEP-0007 - Numeric annotations Oct 16, 2018
@johnbachman
Copy link

How would measurement units be specified where there are multiple values being specified? E.g., there could be numeric annotations associated with the dose of a drug or ligand used in a treatment, as well as the change in an output variable (fold change, amount of cytokine secreted, etc.)

@ncatlett
Copy link
Contributor Author

I would not separate the units from a numeric annotation. Ideally, the units would be included as part of the annotation, e.g., "2 hours"

@cthoyt
Copy link
Contributor

cthoyt commented Nov 14, 2018

Discussion Notes

For a given annotation, is it a namespace annotation, or a numeric one? Could we also have more complicated objects with exotic schemata?

@cthoyt cthoyt changed the title BEP-0007 - Numeric annotations BEP-0007 - Numeric Annotations Nov 24, 2018
@cthoyt cthoyt added this to the BEL v2.2 milestone Aug 1, 2019
@cthoyt cthoyt modified the milestones: BEL v2.2, BEL v2.3 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BEP for numeric annotations
3 participants