Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures extended #114

Merged
merged 2 commits into from
Nov 16, 2019
Merged

Conversation

artem-ogre
Copy link
Contributor

@artem-ogre artem-ogre commented Oct 3, 2019

Added new ligatures that make C++ code formatting nicer (subjectively)
New ligatures: ::, <<, >>, &&, ||, //, /*, */, /**/

I am a huge fan of Fantasque Sans Mono. Thank you very much for your work!
I used beta ligature support and liked it with my code, but I've noticed that some ligatures present in other fonts (e.g., Fira Code) are missing. This pull-request is suggesting introducing some of this ligatures. In my opinion they make typography of my C++ code nicer to look at.

- Regular:                '::', '<<', '>>', '&&', '||', '//', '/*', '*/', '/**/'
- Italic/Bold/BoldItalic:                               '//', '/*', '*/', '/**/'
@artem-ogre
Copy link
Contributor Author

Any feedback? :)

@belluzj
Copy link
Owner

belluzj commented Oct 17, 2019

Thanks for the PR, sorry I'm not spending much time on this project these days. I'll try to review and merge this soon though!

@belluzj belluzj merged commit a16738f into belluzj:ligatures Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants