-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite async code and Remove bluebird #782
Conversation
4f52a99
to
fe780e2
Compare
Woah, many thanks! That seems like a lot of work. Regarding the breaking change, please run rush change to generate a change file that will help the publish scripts bump the version correctly. |
fe780e2
to
57311a7
Compare
Codecov ReportBase: 81.05% // Head: 80.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 81.05% 80.98% -0.08%
==========================================
Files 178 177 -1
Lines 5290 5270 -20
Branches 242 240 -2
==========================================
- Hits 4288 4268 -20
- Misses 931 933 +2
+ Partials 71 69 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing this PR. Since there are many changes and we don’t have enough automated tests, I had to find a focus time to review this in more depth.
There are few concerns with the promise pool API (w.r.t. error handling) and one instance where the .done()
method is removed from a non-Promise.
Thanks again for contributing!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great now! Thank you so much 😄
Resolves #781. This introduces a breaking change on
readAsync
function inbms
package.Changelog
Improved the code that handles asynchronous processing to more closely follow latest coding practices and removed a 3rd party dependency.
For developers using Bemuse’s published npm libraries — there is a breaking change in the
bms
library where thereadAsync
function no longer accepts a callback and now returns a Promise instead.