Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 #186

Closed
PMByrne opened this issue Sep 26, 2017 · 2 comments
Closed

React 16 #186

PMByrne opened this issue Sep 26, 2017 · 2 comments

Comments

@PMByrne
Copy link
Contributor

PMByrne commented Sep 26, 2017

Hi,

react-redux-grid is preventing me from updating to v16 because it has a hard dependency on react and react DOM.

Could new peer dependencies be created and the hard dependencies moved to devDependencies?

"peerDependencies": {
    "font-awesome": "^4.0.0",
    "react": ">=15.0.0 <17.0.0",
    "react-dom": ">=15.0.0 <17.0.0"
}

I would probably consider making the redux dependencies peer dependencies as well.

I do realize this is day 0 and will try to get a pull request made if you can't get to this soon.

@bencripps
Copy link
Owner

This is a great point, and a pull request would be greatly appreciated!

bencripps added a commit that referenced this issue Oct 4, 2017
…all changes in preparation of moving to React@16 -- #186
@bencripps
Copy link
Owner

Thanks for creating this issue, this has been resolved -- a new publish is coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants