adding docs: Actions, Bulk Selection, Types; expose ActionTypes #136

headwinds · 2017-03-08T16:46:42Z

I've started three new docs for Actions, Bulk Selection and Types

Similar to applyGridConfig which has all the Grid Types, I've exposed the ActionTypes but used the simple * approach to pull in everything so now all the types are available and can be listened to from reducers outside of the react-redux-grid library.

import { applyGridConfig } from './constants/GridConstants';
import * as ActionTypes from './constants/ActionTypes';

const modules = {
    Actions,
    Grid,
    GridRootReducer: combineReducers(Reducers),
    Reducers,
    applyGridConfig,
    ActionTypes,
    Store
};

bencripps · 2017-03-08T20:17:53Z

This is so awesome, thanks for the work! I will take a good look at all of this tonight, and leave comments if I have any.

bencripps

Thanks for doing all the hard work! Just a couple of comments for things I'd like to see resolved before the merge.

bencripps · 2017-03-09T15:18:38Z

docs/USING_ACTIONS.md

@@ -0,0 +1,65 @@
+## Actions
+
+Each of the reducers: grid, pager, selection, etc have supporting actions. You may wish to dispatch these actions from other areas of your application outside of the grid. For instance, you could unselect all the rows of the grid that has checkbox column.


Maybe "For instance, you could select all/deselect all rows in a grid from another component in your application"? is a better use case?

Yes, that's better

bencripps · 2017-03-09T15:21:05Z

docs/USING_ACTIONS.md

+Use them in your components from this.props
+
+```
+uncheckAllSelectedRows(event){


Let's remove everything from Use them in your components from this.props down, in this file. Once merged, I'll go back and provide the use case for how best to use the actions.

I'll simply this section to:

Use them in your components from this.props.

// get the all selection row ids const gridMap = this.props.selection.get("myGridStateKey"); const selectedIds = gridMap.get("indexes"); // call a bulk selection action to deselect all the rows const stateKey = "myGridStateKey"; this.props.deselectAll(stateKey);

bencripps · 2017-03-09T15:23:21Z

docs/USING_BULK_SELECTION.md

+#### grid vs dataSource vs selection reducers
+
+const columnData = this.props.grid.get('sticky');
+console.log(JSON.stringify(columnData) ); <-- only column data


Since you can console.log complex objects, we probably don't need the JSON.stringify here.

Can you really?! How do you console log an ordered map to see it's data structure?! amazing if you can...

Articles like this suggest its not possible

Hmm, if it's an ordered map, then let's do console.log(columnData.toJS());

bencripps · 2017-03-09T15:24:28Z

docs/USING_BULK_SELECTION.md

+
+
+
+```


Cant we update the alignment here, or is this just a github issue?

bencripps · 2017-03-09T15:27:12Z

docs/USING_BULK_SELECTION.md

+const columnIndex = 0; 
+updateTabIndex(columnIndex)
+
+#### Disabling Tab Index


Let's remove this part too, we can do this in a more reduxy way. I will update after the merge,

As for this, what I really wanted was to be able to configure the column and pass in tabIndex prop for each one. If I want to disable it, I could pass "-1"

I'll remove my hack ;-D

bencripps · 2017-03-09T15:29:45Z

docs/USING_TYPES.md

+
+You have may other components that may wish to listen to these commands and you can use the React-Redux-Grid types in your own reducers.
+
+#### Grid Types


What are Grid Types -- aren't these the same as Action Types?

Ahh ok... I saw different types within it... there are GirdConstants.js and ActionTypes.js

GridConstants are already exposed as part of applyGridConfig

bencripps · 2017-03-09T15:30:18Z

src/index.js

@@ -8,13 +8,15 @@ import { Reducers } from './reducers';
 import { Actions } from './actions';

 import { applyGridConfig } from './constants/GridConstants';
+import * as ActionTypes from './constants/ActionTypes';


Would you mind removing rootReducer as one of the exports? It was added a loooong time ago, and it's no longer necessary. Thanks!

Do you mean delete these lines?

import { Reducers } from './reducers'; GridRootReducer: combineReducers(Reducers),

?

Just delete the GridRootReducer: combineReducers(Reducers), since we still need to export the Reducers.

If I delete that line, and run the tests...they fail

bencripps · 2017-03-13T14:59:31Z

Your latest commit looks good, except there's a bunch of merge conflicts :( which is why the tests are all failing.

headwinds · 2017-03-13T15:25:03Z

Ok I did do a pull with the upstream master before and found 1 conflict within dataSource which I resolved...

I get a green light on "This branch has no conflicts with the base branch" but that's probably my base master not upstream master...

headwinds · 2017-03-13T15:25:52Z

Why won't it list which files are conflicting now?!

headwinds · 2017-03-13T15:28:28Z

Ok I see dataSource.js is still messed - I'll fix the conflicts

bencripps · 2017-03-13T15:34:49Z

Since you didn't change dataSource, you should probably just checkout the current version of the file from bencripps/master

codecov-io · 2017-03-13T16:08:36Z

Codecov Report

Merging #136 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   81.52%   81.53%   +0.01%     
==========================================
  Files         112      112              
  Lines        4524     4527       +3     
==========================================
+ Hits         3688     3691       +3     
  Misses        836      836

Impacted Files	Coverage Δ
src/index.js	`94.44% <100%> (+1.11%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5039b...ee36d75. Read the comment docs.

headwinds · 2017-03-13T16:10:40Z

So now I just need to squash these comments down ;-D

bencripps · 2017-03-13T17:41:16Z

No need to squash. I'll take a look, and let you know if any other changes are needed. Thanks!

bencripps · 2017-03-13T19:36:41Z

Did we lose some of the changes when you pushed the new code? It looks like we lost some, or am I going crazy?

headwinds · 2017-03-14T01:07:40Z

Nope not crazy - there should have been 5 not 4 files changed - I'm reviewing...I'll see dropped

…s at least 1 type

headwinds · 2017-03-14T01:26:36Z

Make that 6 files - I ran the tests and discovered that exposing AcitonTypes also requires a couple tests

headwinds force-pushed the master branch from 5c6831c to a3a3c32 Compare March 8, 2017 16:53

bencripps force-pushed the master branch from 43bb899 to 906335f Compare March 8, 2017 19:30

bencripps requested changes Mar 9, 2017

View reviewed changes

headwinds added 2 commits March 13, 2017 11:58

adding 3 new docs and exposing Action Types

a4b15bf

added back GritRootReducer so that all tests pass

c0a333e

headwinds force-pushed the master branch from 12e96c1 to c0a333e Compare March 13, 2017 16:03

added ActionTypes to index and added test to ensure it imports and ha…

ee36d75

…s at least 1 type

bencripps approved these changes Mar 14, 2017

View reviewed changes

bencripps merged commit 2a9bdca into bencripps:master Mar 14, 2017

bencripps added a commit that referenced this pull request Mar 14, 2017

clean up from #136

d8ab4e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding docs: Actions, Bulk Selection, Types; expose ActionTypes #136

adding docs: Actions, Bulk Selection, Types; expose ActionTypes #136

headwinds commented Mar 8, 2017

bencripps commented Mar 8, 2017

bencripps left a comment

bencripps Mar 9, 2017

headwinds Mar 13, 2017

bencripps Mar 9, 2017

headwinds Mar 13, 2017

bencripps Mar 9, 2017

headwinds Mar 13, 2017 •

edited

Loading

bencripps Mar 13, 2017

bencripps Mar 9, 2017

headwinds Mar 13, 2017

bencripps Mar 9, 2017

headwinds Mar 13, 2017 •

edited

Loading

bencripps Mar 9, 2017

headwinds Mar 13, 2017

bencripps Mar 9, 2017

headwinds Mar 13, 2017

bencripps Mar 13, 2017

headwinds Mar 13, 2017

bencripps commented Mar 13, 2017

headwinds commented Mar 13, 2017

headwinds commented Mar 13, 2017 •

edited

Loading

headwinds commented Mar 13, 2017

bencripps commented Mar 13, 2017

codecov-io commented Mar 13, 2017 •

edited

Loading

headwinds commented Mar 13, 2017

bencripps commented Mar 13, 2017

bencripps commented Mar 13, 2017

headwinds commented Mar 14, 2017

headwinds commented Mar 14, 2017

		@@ -0,0 +1,65 @@
		## Actions

		Each of the reducers: grid, pager, selection, etc have supporting actions. You may wish to dispatch these actions from other areas of your application outside of the grid. For instance, you could unselect all the rows of the grid that has checkbox column.


		You have may other components that may wish to listen to these commands and you can use the React-Redux-Grid types in your own reducers.

		#### Grid Types




		```

adding docs: Actions, Bulk Selection, Types; expose ActionTypes #136

adding docs: Actions, Bulk Selection, Types; expose ActionTypes #136

Conversation

headwinds commented Mar 8, 2017

bencripps commented Mar 8, 2017

bencripps left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

headwinds Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

headwinds Mar 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bencripps commented Mar 13, 2017

headwinds commented Mar 13, 2017

headwinds commented Mar 13, 2017 • edited Loading

headwinds commented Mar 13, 2017

bencripps commented Mar 13, 2017

codecov-io commented Mar 13, 2017 • edited Loading

Codecov Report

headwinds commented Mar 13, 2017

bencripps commented Mar 13, 2017

bencripps commented Mar 13, 2017

headwinds commented Mar 14, 2017

headwinds commented Mar 14, 2017

headwinds Mar 13, 2017 •

edited

Loading

headwinds Mar 13, 2017 •

edited

Loading

headwinds commented Mar 13, 2017 •

edited

Loading

codecov-io commented Mar 13, 2017 •

edited

Loading