Cascading :rearrange callbacks

[stepantubanov]

Not sure if this is an issue, but if a model has

embeds_many :something, cascade_callbacks: true

Then the embedded model (something) has to have

define_model_callbacks :rearrange

otherwise it throws an exception undefined method _run_rearrange_callbacks when callbacks are run.

[benedikt]

Thanks for reporting!

I think this is an issue, but I'm unsure if it's one with Mongoid::Tree or Mongoid itself. :-)

At the moment I can't think of a good solution to define the missing callbacks on embedded documents without adding them to every document around.

Maybe Mongoid should check if the callbacks are actually available on the embedded document before it tries to call them?

[durran]

I think we can add a check on the Mongoid side if the callback exists here... Better than having the user have to add the definition if it's not used, or mongoid-tree having to monkey patch Mongoid's already monkey patched run_callbacks method.

[durran]

Mongoid issue here: https://github.com/mongoid/mongoid/issues/1887

I flagged for 2.4.8.

[stepantubanov]

Definitely makes sense. Thank you.

[benedikt]

Thanks a lot for your input, @durran :)

[durran]

I've fixed it in Mongoid, on master and 2.4.0-stable. Will be in the 2.4.8 release on Monday.