fix(jsonpatch-apply): support JSON Patch add '/-' for array append #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…restrict '-' to add; robust rollback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the /- path syntax in the JSON Patch add operation, which allows for appending elements to the end of an array. This change aligns our implementation more closely with the behavior specified in RFC 6902 Section 4.1 & A.16.
Key Changes
Array Append with add:
The add operation now correctly interprets a path ending in /- as an instruction to append a value to the target array. For example, a patch like { "op": "add", "path": "/a/b/-", "value": "new" } will add "new" to the end of the array at /a/b.
Strict Path Validation:
The /- path suffix is a special case valid only for the add operation. This PR adds explicit checks to throw an error if a path ending in /- is used with any other operation, preventing incorrect behavior.
Fixed this issue: #434