Address a huge number of TODOs across the codebase #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did some benchmarking and `Object.defineProperty` on a list slows iteration by a third, but just setting the property normally (`arr.hasMore = true`) has negligible impact on iteration performance. Further, I've made it so the property is only set when the list does indeed have more, so more cases should be optimized.
|
Ready to merge; just needs a changeset to be written 😅 |
…d (typically useful for record codecs); so we've eradicated runtime resource definition for columns that use composite types (or lists thereof) - all composite types accessible from attributes are now guaranteed to have a table-like resource generated in the registry.
…o parse values from Postgres.
…d query plan easier to read.
… work, although it is untested.
…ther than a lambda plan.
…l no longer be added.
…SON isn't cast to `::text` and then back to `::json`)
…et rather than the request context, this allows running steps inside special buckets (subscriptions, mutations) to run with a clean cache.
… at a time when doing so is forbidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.