Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider using prosemirror-autocomplete instead of prosemirror-suggest #44

Closed
benrbray opened this issue Apr 29, 2023 · 4 comments · Fixed by #47
Closed

consider using prosemirror-autocomplete instead of prosemirror-suggest #44

benrbray opened this issue Apr 29, 2023 · 4 comments · Fixed by #47
Labels
dependencies Pull requests that update a dependency file editor

Comments

@benrbray
Copy link
Owner

benrbray commented Apr 29, 2023 •
edited
Loading

the existing suggestion popup needs a makeover, so I need to decide between:

  1. keep using prosemirror-suggest
  2. switch to prosemirror-autocomplete
  3. build my own solution
@rowanc1
Copy link

rowanc1 commented Apr 29, 2023

If there is something that needs changing over in prosemirror-autocomplete, happy to try and make it happen. It has worked well for us over in Curvenote.

@benrbray benrbray added the dependencies Pull requests that update a dependency file label Apr 29, 2023
@benrbray benrbray mentioned this issue Apr 30, 2023
Merged
6 tasks
@benrbray
Copy link
Owner Author

benrbray commented May 3, 2023

@rowanc1 Thanks very much for the prosemirror-autocomplete package, it's great! I've decided to switch from prosemirror-suggest to prosemirror-autocomplete, because:

  • I find prosemirror-autocomplete a bit easier to use, since it handles just the autocompletion and gives me freedom to handle the autocomplete events however I want
  • prosemirror-autocomplete depends only on core prosemirror modules, while prosemirror-suggest pulls in many extra dependencies like remirror and react that were giving me compilation issues

I opened a small PR curvenote/editor#185 to add a cancelOnSpace option, let me know what you think!

@rowanc1
Copy link

rowanc1 commented May 3, 2023

So awesome! Glad it is working for you!

I will take a look at the PR soon, thanks for the detailed write up.

benrbray added a commit that referenced this issue May 3, 2023
@benrbray
(#44) replace prosemirror-suggest with prosemirror-autocomplete
f0ec7f8
This was referenced May 3, 2023
Closed
Open
benrbray added a commit that referenced this issue May 4, 2023
@benrbray
Merge pull request #47 from benrbray/benrbray/gh43/abolish-webpack-us…
2a6b880 
…e-vite

[#43] replace `webpack` with `vite` and `electron-vite`
[#44] replace `prosemirror-suggest` with `prosemirror-autocomplete`
@benrbray
Copy link
Owner Author

benrbray commented May 4, 2023

Merged! Code for the autocomplete extension can be found here.

noteworthy-autocomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[gh43] replace webpack with vite and electron-vite benrbray/noteworthy
2 participants
@benrbray @rowanc1