Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty space in multi-page field layout #2538

Merged
merged 2 commits into from
May 5, 2021
Merged

Fix empty space in multi-page field layout #2538

merged 2 commits into from
May 5, 2021

Conversation

kolking
Copy link
Collaborator

@kolking kolking commented May 2, 2021

Re #2501 - This is how I've changed the condition to show .fields-row (based on your suggestion in Slack)

-page_number = array.map{|field| field.page_number}.uniq.first
-if (@page && (page_number == @page.position || page_number == nil)) || (current_page?({action: 'edit_fields'}))

@kolking kolking requested review from benwbrum and saracarl May 2, 2021 18:05
@coveralls
Copy link

coveralls commented May 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 81.517% when pulling fbd3345 on 2501-multi-page-fields into 0b7d3a9 on development.

@saracarl saracarl merged commit 84e7f52 into development May 5, 2021
@saracarl saracarl deleted the 2501-multi-page-fields branch May 5, 2021 19:44
sylvieed pushed a commit that referenced this pull request Jul 14, 2022
@saracarl
Merge pull request #2538 from benwbrum/2501-multi-page-fields
ce348c2 
Fix empty space in multi-page field layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwbrum benwbrum Awaiting requested review from benwbrum

@saracarl saracarl Awaiting requested review from saracarl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolking @coveralls @saracarl