(Issue 3403) Fix iOs left hand nav sliding choppiness #50
Conversation
| @@ -541,6 +541,8 @@ div.oae-thumbnail i[class^="icon-"] { | |||
| margin: -16px 10px 10px; | |||
There was a problem hiding this comment.
Can you reorder the added CSS alphabetically?
|
Works consistently across the devices I tested, only some minor comments remaining. |
|
Followed up on review. @BP323 |
|
@timdegroote I found a functional issue with the share widget in the left hand navigation on IE9. it looks like it's not overflowing properly and get cuts off where the list ends. |
|
Committed a fix which also takes care of some other issues. @BP323 |
|
@timdegroote could you have a look at fixing the merge conflict? |
…ue-3403 Conflicts: shared/oae/js/jquery-plugins/jquery.responsive.js
|
|
||
| /** | ||
| * Open the left hand navigation | ||
| * Toggle the left hand navigation. Throttle the function to prevent it from being triggered during animation. | ||
| * @param {Boolean} visible Determines whether the left hand navigation should be shown (true) or hidden (false). |
There was a problem hiding this comment.
It'd make more sense to rename this to showNav I think.
|
Some comments remaining, reassigning to @timdegroote for followup |
|
Follow-up done @BP323 |
|
Functionality is working as expected and code looks good, just a few minor doc updates suggested. |
|
Submitted a follow-up @BP323 |
|
@timdegroote can you fix the merge conflict |
…ue-3403 Conflicts: shared/oae/css/oae.components.css
|
Merge conflict should be fixed @BP323 |
|
Looks good, ready to merge. |
|
Closing in favor of oaeproject#3522 |
Fix embargo date validation
No description provided.