Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: able to join peer into channels;bug fix on channel creation #71

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

bjwswang
Copy link
Member

@bjwswang bjwswang commented Jan 31, 2023

Fix: #36

Signed-off-by: bjwswang bjwswang@gmail

Changelogs

  1. fixed channel creation bug: tlsca not working in fabric-ca
  2. able to join peers into channel
  3. save channel list in network.status.channels
  4. fix orderer override on network creation which should use tlsca in tls
  5. re-enable integration test (set OPERTOR_USER_TYPE to sa by default)
  6. fix golangci-lint test: bug from golangci-lint (Go 1.18.4 and golangci 1.48: "Error: File is not gofmt-ed with -s (gofmt)" golangci/golangci-lint-action#535 )

@bjwswang bjwswang marked this pull request as draft February 1, 2023 01:28
@bjwswang bjwswang force-pushed the 36-develop-channel-crd branch 3 times, most recently from 3709d94 to 0267aba Compare February 1, 2023 02:40
Signed-off-by: bjwswang <bjwswang@gmail>

Changelogs
    1. fixed channel creation bug: tlsca not working in fabric-ca
    2. able to join peers into channel
    3. save channel list in network.status.channels
    4. fix orderer override on network creation which should use tlsca in tls
    5. fix peer unit test
    6. fix golangci-lint test: bug from latest version of golangci-lint(golangci/golangci-lint-action#535)
@bjwswang bjwswang marked this pull request as ready for review February 1, 2023 02:45
Copy link
Member

@Abirdcfly Abirdcfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@bjwswang bjwswang merged commit eee78f2 into bestchains:main Feb 1, 2023
@bjwswang bjwswang deleted the 36-develop-channel-crd branch February 2, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop Channel CRD
2 participants