Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete #2889

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

haslinghuis
Copy link
Member

Fix savedMouseoverItemHandler which intermittent prevents cli auto complete to function:

CliAutoComplete.js:294 Uncaught TypeError: Cannot read properties of undefined (reading '0')
    at HTMLTextAreaElement.<anonymous> (CliAutoComplete.js:294:100)
    at HTMLTextAreaElement.dispatch (jquery.min.js:2:43090)
    at HTMLTextAreaElement.v.handle (jquery.min.js:2:41074)
    at Object.trigger (jquery.min.js:2:71513)
    at HTMLTextAreaElement.<anonymous> (jquery.min.js:2:72108)
    at Function.each (jquery.min.js:2:2976)
    at S.fn.init.each (jquery.min.js:2:1454)
    at S.fn.init.trigger (jquery.min.js:2:72084)
    at b.fire (jquery.textcomplete.min.js:2:3629)
    at b.activate (jquery.textcomplete.min.js:2:7021)
    at jquery.textcomplete.min.js:2:4219
    at searcher (CliAutoComplete.js:237:9)
    at Object.search (CliAutoComplete.js:351:17)
    at b.<anonymous> (jquery.textcomplete.min.js:2:4167)
    at b._search (jquery.textcomplete.min.js:2:2071)
    at b.trigger (jquery.textcomplete.min.js:2:3487)

@haslinghuis haslinghuis added this to the 10.8.0 milestone Apr 9, 2022
@haslinghuis haslinghuis self-assigned this Apr 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Debug-Android
Betaflight-Configurator-Debug-Linux
Betaflight-Configurator-Debug-macOS
Betaflight-Configurator-Debug-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Apr 10, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@limonspb limonspb merged commit b2a33de into betaflight:master Apr 12, 2022
@haslinghuis haslinghuis deleted the fix_cli_autocomplete branch April 12, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants