Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix H7EXTREME #12596

Merged
merged 1 commit into from Apr 4, 2023
Merged

Fix H7EXTREME #12596

merged 1 commit into from Apr 4, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Mar 29, 2023

  • Fixes configuration as power cycling was putting the board in DFU mode.
  • SDCard for Blackbox is not recognized. Using SPI flash instead.
  • Added timer map and dma options

@haslinghuis haslinghuis added this to the 4.5 milestone Mar 29, 2023
@haslinghuis haslinghuis self-assigned this Mar 29, 2023
@github-actions

This comment has been minimized.

@haslinghuis haslinghuis force-pushed the fix-h7extreme branch 2 times, most recently from e81c2cd to bacde9b Compare March 29, 2023 21:33
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member

blckmn commented Mar 30, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@hydra
Copy link
Contributor

hydra commented Mar 30, 2023

  • Fixes configuration as power cycling was putting the board in DFU mode.

this is caused by a mismatch between where the bootloader expects the config and firmware to be saved and where BF was actually saving the config - it was overwriting the firmware partition with the config. the BL will boot from RAM when any previously-loaded firmware is present there. After a power cycle the BL would try loading from flash again, but the firmware will have been corrupted by BF overwriting it with config. the MD5 hash and hashing technique employed by the bootloader worked perfectly and put the FC in DFU mode ready to be flashed with fixed firmware.

* [x]  SDCard for Blackbox is not recognized. Using SPI flash instead.

It's not clear what this PR does. Does SDCard for BB logging now work or does this PR disable SDCard for BB logging? If the latter why?

@haslinghuis
Copy link
Member Author

haslinghuis commented Mar 30, 2023

@hydra Yes please have a look.

With 4.3.1 SDCard is available in blackbox logger tab as default.
With 4.5.0 SDCard option is absent.

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Assets
WARNING: It may be unstable. Use only for testing! See: https://www.youtube.com/watch?v=I1uN9CN30gw for instructions for unified targets!

@blckmn blckmn merged commit e382c3e into betaflight:master Apr 4, 2023
19 checks passed
@haslinghuis haslinghuis deleted the fix-h7extreme branch April 4, 2023 16:05
davidbitton pushed a commit to davidbitton/betaflight that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants