Skip to content

Tweak tree-menu styling #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

Tweak tree-menu styling #1153

merged 1 commit into from
May 7, 2024

Conversation

doup
Copy link
Contributor

@doup doup commented May 4, 2024 •
edited
Loading

Minor tweaks to tree-menu BEM component used in most of the sidebar menus. Changes:

  • Reduce horizontal padding to 12px
  • Reduce sub-menu (ul > ul) items offset to 12px
  • Remove border-radius to the open/close chevron
  • Increase line-height for better legibility in multi-line entries
  • Balance text in multi-line entries when possible (avoids widows and should look more "balanced")

DEMO BEFORE/AFTER

Warning

Ignore cursor icon in the video, the video recording app sometimes messes the cursor.

bevy-tweak-tree-menu-styling.mp4

NthTensor
NthTensor approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@NthTensor NthTensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much nicer.

@TrialDragon TrialDragon added C-Feature A new feature, making something new possible S-Ready-For-Final-Review Ready for a maintainer to consider for merging C-Webdev labels May 5, 2024
@cart cart added this pull request to the merge queue May 7, 2024
Merged via the queue into bevyengine:main with commit 37ecaa0 May 7, 2024
@doup doup deleted the feature/tweak-tree-menu branch May 8, 2024 06:31
@doup doup mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

+3 more reviewers

@SIGSTACKFAULT SIGSTACKFAULT SIGSTACKFAULT approved these changes

@NthTensor NthTensor NthTensor approved these changes

@TrialDragon TrialDragon TrialDragon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C-Feature A new feature, making something new possible C-Webdev S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@doup @cart @SIGSTACKFAULT @NthTensor @TrialDragon