FromTemplate field defaults (ImageRenderTargetTemplate::scale_factor defaults to 0)

[rectalogic]

bevy::camera::ImageRenderTargetTemplate::scale_factor defaults to 0 which is not valid and results in a panic when used.

So this doesn't work:

    let image = Image::new_target_texture(0, 0, TextureFormat::Bgra8UnormSrgb, None);
    bsn! {
        RenderTarget::Image(ImageRenderTargetTemplate {
            handle: asset_value(image),
        })
    }

You need to be explicit:

    bsn! {
        RenderTarget::Image(ImageRenderTargetTemplate {
            handle: asset_value(image),
            scale_factor: 1.0,
        })
    }

However this results in a clippy warning because the FromTemplate derive adds ..Default::default() and we already specified all fields:

struct update has no effect, all the fields in the struct have already been specified
for further information visit https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#needless_update
#[warn(clippy::needless_update)] on by default (clippy needless_update)

Should the FromTemplate derive support a #[template(default = XX)] field annotation, so then ImageRenderTarget could be defined as:

#[derive(FromTemplate, Debug, Clone, Reflect)]
#[reflect(Clone, PartialEq, Hash)]
pub struct ImageRenderTarget {
    /// The image to render to.
    pub handle: Handle<Image>,
    /// The scale factor of the render target image, corresponding to the scale
    /// factor for a window target. This should almost always be 1.0.
    #[template(default = 1.0)]
    pub scale_factor: f32,
}

bevy/crates/bevy_camera/src/camera.rs

Lines 985 to 993 in c9c21c2

	#[derive(FromTemplate, Debug, Clone, Reflect)]
	#[reflect(Clone, PartialEq, Hash)]
	pub struct ImageRenderTarget {
	/// The image to render to.
	pub handle: Handle<Image>,
	/// The scale factor of the render target image, corresponding to the scale
	/// factor for a window target. This should almost always be 1.0.
	pub scale_factor: f32,
	}