Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ArchetypeEntity::entity into ArchetypeEntity::id #11118

Merged
merged 2 commits into from
Jan 1, 2024

Conversation

tharnival
Copy link
Contributor

Objective

Fixes #11050

Rename ArchetypeEntity::entity to ArchetypeEntity::id to be consistent with EntityWorldMut, EntityMut and EntityRef.

Migration Guide

The method ArchetypeEntity::entity has been renamed to ArchetypeEntity::id

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@matiqo15 matiqo15 added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Dec 28, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 28, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 28, 2023
@james7132 james7132 added this pull request to the merge queue Jan 1, 2024
Merged via the queue into bevyengine:main with commit ffded5b Jan 1, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ArchetypeEntity::entity into ArchetypeEntity::id
4 participants