Fix UV coords in generate_custom_mesh example
#12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
NthTensor
added
C-Examples
kristoff3r
approved these changes
Apr 1, 2024
mockersf
approved these changes
Apr 1, 2024
mockersf
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
chompaa
pushed a commit
to chompaa/bevy
that referenced
this pull request
Apr 5, 2024
# Objective Fix the last coordinate of the top side in the `generate_custom_mesh` example. Fixes bevyengine#12822 ## Images Added a yellow square to the texture to demonstrate as suggested in [the issue](bevyengine#12822). <details> <summary>Texture:</summary> <img src="https://github.com/bevyengine/bevy/assets/70668395/c605e916-bb02-4247-bf24-2f033c650419" /> </details> <details> <summary>Before:</summary> <img src="https://github.com/bevyengine/bevy/assets/70668395/e67b592b-8001-42e3-a6ce-7d62ad59bf81" /> </details> <details> <summary>After:</summary> <img src="https://github.com/bevyengine/bevy/assets/70668395/e9194784-ee4a-4848-87c2-0eb54e05236c" /> </details> ## Solution Change the coordinate from 0.25 to 0.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix the last coordinate of the top side in the
generate_custom_meshexample.Fixes #12822
Images
Added a yellow square to the texture to demonstrate as suggested in the issue.
Texture:
Before:
After:
Solution
Change the coordinate from 0.25 to 0.2.