Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc custom CameraProjection requires use of plugin #13140

Merged

Conversation

Zoomulator
Copy link
Contributor

Objective

Documentation should mention the two plugins required for your custom CameraProjection to work.

Solution

Documented!


I tried linking to bevy_pbr::PbrProjectionPlugin from bevy_render::camera::CameraProjection but it wasn't in scope. Is there a trick to it?

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate that the required plugin is in bevy_pbr, but that's not this PR's problem.

@Zoomulator Zoomulator force-pushed the doc-use-cameraprojectionplugin branch from 2b68a52 to f7e09b8 Compare April 29, 2024 14:56
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Apr 29, 2024
Copy link
Contributor

@pablo-lua pablo-lua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and needed comment.

@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 5, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 5, 2024
Merged via the queue into bevyengine:main with commit d1099ac May 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants