Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example render_to_texture: remove extra light #13398

Merged
merged 1 commit into from
May 16, 2024
Merged

example render_to_texture: remove extra light #13398

merged 1 commit into from
May 16, 2024

Conversation

mockersf
Copy link
Member

Objective

  • in example render_to_texture, #12502 Remove limit on RenderLayers. #13317 changed the comment on the existing light saying lights don't work on multiple layers, then add a light on multiple layers explaining that it will work. it's confusing

Solution

  • Keep the original light, with the updated comment

Testing

  • Run example render_to_texture, lighting is correct

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels May 16, 2024
@mockersf mockersf added this to the 0.14 milestone May 16, 2024
tychedelia
tychedelia approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for not cleaning this up correctly.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 16, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 16, 2024
Merged via the queue into bevyengine:main with commit 104dcf5 May 16, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychedelia tychedelia tychedelia approved these changes

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @rparrett @tychedelia @alice-i-cecile