Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when an asset load failure event is processed after asset drop #14123

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix crash when an asset load failure event is processed after asset drop #14123

merged 1 commit into from
Jul 8, 2024

Conversation

brianreavis
Copy link
Contributor

Objective

This PR fixes a crash that happens when an asset failure event is processed after the asset has already been dropped.

2024-07-03T17:12:16.847178Z ERROR bevy_asset::server: Encountered HTTP status 404 when loading asset
thread 'main' panicked at bevy/crates/bevy_asset/src/server/info.rs:593:18:

Solution

  • Update process_asset_fail to match the graceful behavior in process_asset_load (it does not assume the state still exists).

Changelog

  • Fixed a rare crash that happens when an asset failed event is processed after the asset has been dropped.

@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds P-Crash A sudden unexpected crash labels Jul 3, 2024
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit 7273ffc Jul 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds D-Trivial Nice and easy! A great choice to get started with Bevy P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianreavis @alice-i-cecile @mockersf @janhohenheim