Skip to content

dont hard code clustering limits on cpu side so they can be informed by Limits later #19985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2025
Merged

dont hard code clustering limits on cpu side so they can be informed by Limits later #19985

merged 1 commit into from
Jul 6, 2025

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jul 6, 2025

Objective

  • prepare bevy_light for split
  • make limits more dynamically configurable

Solution

  • use settings struct

Testing

  • 3d_scene, lighting

alice-i-cecile
alice-i-cecile approved these changes Jul 6, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please. I really prefer this direction of API: more dynamic config-driven settings, better use of detected limits.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 6, 2025
@alice-i-cecile alice-i-cecile requested a review from JMS55 July 6, 2025 18:51
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 6, 2025
Merged via the queue into bevyengine:main with commit 5b38989 Jul 6, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jul 6, 2025
@atlv24 atlv24 deleted the ad/unhardcode branch July 23, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atlv24 @alice-i-cecile @JMS55