Return an error from Assets::insert instead of panicking.
#20439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
D-Trivial
andriyDev
force-pushed
the
fix-invalid-handles
branch
from
aa8345e to
891caa0
Compare
janhohenheim
approved these changes
Aug 6, 2025
andriyDev
added
S-Ready-For-Final-Review
james7132
added
the
M-Needs-Migration-Guide
greeble-dev
approved these changes
Aug 6, 2025
Co-authored-by: Greeble <166992735+greeble-dev@users.noreply.github.com>
james7132
approved these changes
Aug 10, 2025
gwafotapa
pushed a commit
to gwafotapa/bevy
that referenced
this pull request
Aug 12, 2025
…ne#20439) # Objective - Inserting into a dropped AssetId would panic. There is no API to check if the asset ID is still valid, so you can't avoid this case. For a concrete example, imagine a user uses `Assets::reserve_handle` to get a handle, and then passes its AssetId into an async task. While the async task is running, the user drops the handle, which removes the entry from `Assets`. Later when the async task returns, it tries to insert the asset into that `AssetId`. This previously caused a panic. [Based on a true story](https://discord.com/channels/691052431525675048/749332104487108618/1402511976898498590). ## Solution - Make `Assets::insert` return an error when inserting into a dropped `AssetId`. ## Testing - Added a test specifically for this case. --------- Co-authored-by: Greeble <166992735+greeble-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
For a concrete example, imagine a user uses
Assets::reserve_handleto get a handle, and then passes its AssetId into an async task. While the async task is running, the user drops the handle, which removes the entry fromAssets. Later when the async task returns, it tries to insert the asset into thatAssetId. This previously caused a panic. Based on a true story.Solution
Assets::insertreturn an error when inserting into a droppedAssetId.Testing