Naive support for system fonts #21396
Open
+260
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I was working on this and noticed a superior implementation in #16365. However, I am unsure of the general consensus on loading system fonts. This PR uses the existing
Font
asset to query the system directly for fonts.Solution
Font
to include aFont::System
variant.TextPlugin
to include aload_system_fonts
parameterTesting
examples/system_fonts
Showcase
A font can be added with with the new
Font::System
variant:Note
I would love to enable System Fonts through this PR or via #16365. Please let me know what I need to do to make this possible!