[Merged by Bors] - use alpha mask even when unlit #6047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceSentry
added
A-Rendering
|
this also causes the alpha channel to be forced to 1.0 for unlit+opaque so it's not a raw passthrough of the input value any more. i think that's fine though, i can't see a good reason to use opaque with an alpha < 1.0. for unlit+blend the behaviour will be unchanged, and for unlit+mask the alpha will be 0 or 1 as expected. |
mockersf
approved these changes
Sep 26, 2022
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
# Objective - Alpha mask was previously ignored when using an unlit material. - Fixes #4479 ## Solution - Extract the alpha discard to a separate function and use it when unlit is true ## Notes I tried calling `alpha_discard()` before the `if` in pbr.wgsl, but I had errors related to having a `discard` at the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.
|
Build failed: |
|
@IceSentry this PR needs to be updated with latest main and the spawn bundle changes |
IceSentry
force-pushed
the
alpha-unlit
branch
from
c957cd3
to
35efe59
Compare
|
Done. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 28, 2022
# Objective - Alpha mask was previously ignored when using an unlit material. - Fixes #4479 ## Solution - Extract the alpha discard to a separate function and use it when unlit is true ## Notes I tried calling `alpha_discard()` before the `if` in pbr.wgsl, but I had errors related to having a `discard` at the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
# Objective - Alpha mask was previously ignored when using an unlit material. - Fixes bevyengine#4479 ## Solution - Extract the alpha discard to a separate function and use it when unlit is true ## Notes I tried calling `alpha_discard()` before the `if` in pbr.wgsl, but I had errors related to having a `discard` at the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Alpha mask was previously ignored when using an unlit material. - Fixes bevyengine#4479 ## Solution - Extract the alpha discard to a separate function and use it when unlit is true ## Notes I tried calling `alpha_discard()` before the `if` in pbr.wgsl, but I had errors related to having a `discard` at the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Alpha mask was previously ignored when using an unlit material. - Fixes bevyengine#4479 ## Solution - Extract the alpha discard to a separate function and use it when unlit is true ## Notes I tried calling `alpha_discard()` before the `if` in pbr.wgsl, but I had errors related to having a `discard` at the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Notes
I tried calling
alpha_discard()before theifin pbr.wgsl, but I had errors related to having adiscardat the beginning before doing the texture sampling. I'm not sure if there's a way to fix that instead of having the function being called in 2 places.