Dither fix #7977
Merged
Dither fix #7977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
aevyrie
reviewed
Mar 24, 2023
mockersf
pushed a commit
that referenced
this pull request
Mar 27, 2023
- Fixes #7965 - Code quality improvements. - Removes the unreferenced function `dither` in pbr_functions.wgsl introduced in 72fbcc7, but made obsolete in c069c54. - Makes the reference to `screen_space_dither` in pbr.wgsl conditional on `#ifdef TONEMAP_IN_SHADER`, as the required import is conditional on the same, as deband dithering can only occur if tonemapping is also occurring. --------- Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ditherin pbr_functions.wgsl introduced in 72fbcc7, but made obsolete in c069c54.screen_space_ditherin pbr.wgsl conditional on#ifdef TONEMAP_IN_SHADER, as the required import is conditional on the same, as deband dithering can only occur if tonemapping is also occurring.