-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Globals struct to prepass shader #8070
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is complaining about formatting. Please run cargo fmt
and update the PR. Plus leave the new line at the end of the shader as commented. Then we can get this merged.
@@ -15,4 +18,4 @@ var<uniform> mesh: Mesh; | |||
@group(2) @binding(1) | |||
var<uniform> joint_matrices: SkinnedMesh; | |||
#import bevy_pbr::skinning | |||
#endif | |||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing new line
Does this count as a breaking change? The bindings for the shader do seem like a public interface that should be governed by semver. |
Conservatively assigning this to 0.11 for now, feel free to move to 0.10.1 if this shouldn't be considered breaking. |
I agree it probably is a breaking change to the shader interfaces. |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
Objective
Solution