Expose AudioSink::empty()
#8145
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
I rebased on main to fix the diff (it was including changelog and publish changes)
examples/audio/audio_empty.rs
Outdated
| @@ -0,0 +1,35 @@ | |||
| use bevy::prelude::*; | |||
There was a problem hiding this comment.
Definitely a matter of preference, but I don't think we need an example just to illustrate the empty method. With that criteria we'd have thousands of examples.
There was a problem hiding this comment.
You could update one of the existing audio example, like audio_control, to exit once the sink is empty
There was a problem hiding this comment.
I just think its solving a problem that doesn't need to be solved. I think we should wait until the demand for such an example presents itself.
3 participants
Objective
Exposes
empty()method forAudioSink.Based on
0.10.0, should be a non-breaking change.Changelog
empty()method forAudioSinkAudioSink::empty()example