Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce comments about frustum culling #8579

Merged
merged 4 commits into from
May 9, 2023
Merged

Re-introduce comments about frustum culling #8579

merged 4 commits into from
May 9, 2023

Conversation

hate
Copy link
Contributor

@hate hate commented May 9, 2023

Objective

Frustum culling for 2D components has been enabled since #7885,
Fixes #8490

Solution

Re-introduced the comments about frustum culling in the many_animated_sprites.rs and many_sprites.rs examples.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@nicopap nicopap added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels May 9, 2023
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: François <mockersf@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 9, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 9, 2023
Merged via the queue into bevyengine:main with commit b4218a4 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document frustum culling in 2d examples
4 participants