Laravel 5.8 support #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
merge? <3 or is this not sufficient? |
|
Please merge |
mpociot
reviewed
Apr 26, 2019
|
@mpociot hope you had a great vacation! Just going to ping you on this to merge when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need this package in a project I'm working on.
Since there's no (yet) support for Laravel 5.8 I decided to make one :)
In this PR I've just bumped package versions. This (+simple fix in a test case) was enough to make the tests pass.
I have to admit that I didn't test this on a real Laravel installation.