Skip to content

Conversation

janpio
Copy link
Contributor

@janpio janpio commented Jul 18, 2018

Namespace \ was getting eaten.

fixes part of #9

Namespace \ was getting eaten.

fixes part of #9
@mpociot
Copy link
Member

mpociot commented Jul 18, 2018

Hmm this is more an issue with how the relation name can be detected. If you use the relation as a query builder and not just as a property, I can not get access to the relation name. Then I only know about the related class.
So eager loading this would not have any effect at all.
Maybe we should detect if it’s a class name or a property and change the alert / log message in this case.

@janpio
Copy link
Contributor Author

janpio commented Jul 18, 2018

Fundamentally you might be right, I don't know enough about that.

But for now the addslashes() is there in one place, and not the other - so easily fixable ;)

@mpociot mpociot merged commit 7f85d1f into beyondcode:master Jul 19, 2018
@janpio janpio deleted the patch-1 branch July 19, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants