Skip to content

Expanded the console log warning with the same details as the laravel.log #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

erikverbeek
Copy link
Contributor

I have expanded the information given in the console warning to have the same level of details as the Log output. This way you don't have to dive into the log each time to find the precise file and line that the query is on. It's all available in the front-end.

@erikverbeek
Copy link
Contributor Author

I'm not sure how to trigger another run from Travis to get the last test to green. It seems there was an error downloading the PHP 7.2 package from Amazon when the test ran.

@erikverbeek
Copy link
Contributor Author

@mpociot Any tips on getting Travis to green?

@erikverbeek
Copy link
Contributor Author

I closed & re-opened the issue to get Travis to run again and pass all it's tests.

@mpociot Anything else I can do to get this request accepted?

@mpociot mpociot merged commit ad3df19 into beyondcode:master Aug 8, 2018
@mpociot
Copy link
Member

mpociot commented Aug 8, 2018

Not sure what was wrong with Travis - thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants