Integration with ajax requests #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlodes
suggested changes
May 21, 2020
|
|
||
| $validateContentTypeHTML = true; | ||
|
|
||
| if (env('QUERY_DETECTOR_AJAX', false)) { |
There was a problem hiding this comment.
You need to use config(...), not env(...) because when config are cached env() will always return null.
Config reference:
https://laravel.com/docs/7.x/configuration#configuration-caching
|
|
||
| return $output; | ||
| } | ||
| } | ||
| } |
| $output .= "\\n"; | ||
| if (!request()->ajax()) { | ||
| $output = '<script type="text/javascript">'; | ||
| $output .= "alert('Found the following N+1 queries in this request:\\n\\n"; |
There was a problem hiding this comment.
I suggest another way.
Maybe blade template will look better?
| $output .= "Model: ".addslashes($detectedQuery['model'])." => Relation: ".addslashes($detectedQuery['relation']); | ||
| $output .= " - You should add \"with(\'".addslashes($detectedQuery['relation'])."\')\" to eager-load this relation."; | ||
| $output .= "\\n"; | ||
| if (!request()->ajax()) { |
|
|
||
| ``` javascript | ||
| $(document).ajaxComplete(function(event, response){ | ||
| if (typeof response.responseJSON.laravelQueryDetector != 'undefined') { |
There was a problem hiding this comment.
Suggested change
| if (typeof response.responseJSON.laravelQueryDetector != 'undefined') { | |
| if (typeof response.responseJSON.laravelQueryDetector !== 'undefined') { |
|
What's the status of this PR? I'd love to use query-detector but most of my requests are async via javascript so right now it basically detects nothing. |
|
I'll close this. Feel free to do create another PR with the reviewed suggestions and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration with ajax requests to show the alert when an N+1 is detected