Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

PHP 8.2 Build and Fix Tests #1047

Closed
wants to merge 2 commits into from
Closed

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Oct 18, 2022

You can't use $this->components because it is @internal

protected function startServer()
{
$this->components->info("Starting the WebSocket server on port {$this->option('port')}...");
$this->comment(' <fg=yellow;options=bold>Press Ctrl+C to stop the server</>');

@internal This property is not meant to be used or overwritten outside the framework.

https://github.com/laravel/framework/blob/a8a529d371faaa38bde087aa6171a5b53a6a8760/src/Illuminate/Console/Concerns/InteractsWithIO.php#L18-L25

@internal This property is not meant to be used or overwritten outside the framework.
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Merging #1047 (43e8a0b) into master (1f25913) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1047      +/-   ##
============================================
+ Coverage     90.94%   91.34%   +0.39%     
- Complexity        0        2       +2     
============================================
  Files            68       68              
  Lines          1866     2056     +190     
============================================
+ Hits           1697     1878     +181     
- Misses          169      178       +9     
Impacted Files Coverage Δ
src/Console/Commands/StartServer.php 84.68% <100.00%> (+1.17%) ⬆️
src/Server/HealthHandler.php 66.66% <0.00%> (-33.34%) ⬇️
src/Server/MockableConnection.php 66.66% <0.00%> (-33.34%) ⬇️
src/Cache/RedisLock.php 77.41% <0.00%> (-1.16%) ⬇️
src/Helpers.php 100.00% <0.00%> (ø)
src/API/FetchUsers.php 100.00% <0.00%> (ø)
src/DashboardLogger.php 100.00% <0.00%> (ø)
src/API/FetchChannel.php 100.00% <0.00%> (ø)
src/API/FetchChannels.php 100.00% <0.00%> (ø)
src/Statistics/Statistic.php 100.00% <0.00%> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erikn69 erikn69 mentioned this pull request Oct 18, 2022
@what-the-diff
Copy link

what-the-diff bot commented Oct 20, 2022

  • Added PHP 8.2 to the matrix
  • Updated composer dependencies for Laravel 9 support
  • Fixed a bug where $this->components was used instead of $this->info() in StartServer command

@Wernke96
Copy link

@mpociot could you take a look at this pr.

@parallels999
Copy link

@mpociot ping :/

@angeljqv
Copy link

@mpociot hi, still there?

@mpociot mpociot closed this Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants