New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional server variable #14

Merged
merged 3 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@LKaemmerling
Contributor

LKaemmerling commented Dec 5, 2018

This PR fixes #12

It is now possible to easily configure the server, which the dashboard connects to.

My setup is the following:
I have one server (the webserver) which is hosting the dashboard: dev.my.app
The socket server is running under ws-dev.my.app

Without this PR, the dashboard tries to conntect to dev.my.app because, in the connect section window.location.hostname is used. This behavior is after this pr still the same, except someone fills the new 'server' configuration variable. Then this value will be used.

@mpociot

Thank you for the PR!
Can you please adjust the code a little:
I think host would be a better fit for the property than server. Can you rename that?

And please remove the changes in the default configuration file. We will address this in the documentation, as it seems be a bit confusing to have a null value in the default configuration.

@LKaemmerling

This comment has been minimized.

Contributor

LKaemmerling commented Dec 5, 2018

Sure :) Changed to host and i removed the line from the default config file.

@mpociot mpociot merged commit f03acd1 into beyondcode:master Dec 5, 2018

3 checks passed

Scrutinizer 1 updated code elements
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment