-
Notifications
You must be signed in to change notification settings - Fork 660
Feature apps from database table #90
Conversation
…/laravel-websockets into feature-database-apps # Conflicts: # src/Database/Console/AppCreate.php # src/WebSocketsServiceProvider.php
…/laravel-websockets into feature-database-apps
…/laravel-websockets into feature-database-apps
looks really useful! thanks for working on this! I have two comments. First, instanciate is misspelled, it should be instantiate Second, in all of my websocket apps I use a conditional when setting the host, like this:
Can your addition have any way of handling such a case ? |
@vesper8 thanks for the first comment. About the second, i think that if you're not using the same database on production and local, the problem is not real. |
@masterix21 good point! didn't think of that is it possible to enable/disable apps without deleting them? |
App model uses SoftDelete trait, but i will manage better enable/disable feature. Thanks |
|
this is great feature... please merge it :) |
Until this has been merged or if you want to do it in Nova you can use this package |
* Fix Laravel 5.8 compatibility * Use Arr:: and Str:: instead of global helpers * Remove testbench-core dependency, release was tagged
Add support for overriding stats logger's base URL
Revert "Add support for overriding stats logger's base URL"
[feature] Codecov
…/laravel-websockets into feature-database-apps # Conflicts: # src/Database/Console/AppCreate.php # src/WebSocketsServiceProvider.php
@masterix21 I assume you need to update your fork's master branch with the current one. |
To create an app from command line:
php artisan websockets:app:create
To manage all existing apps, use the web panel from your browser:
/laravel-websockets/admin