Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Laravel 9.x Compatibility #930

Closed

Conversation

laravel-shift
Copy link

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 9. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-websockets.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "beyondcode/laravel-websockets": "dev-l9-compatibility",
    }
}

Finally, run: composer update

@joecampo
Copy link
Contributor

joecampo commented Feb 8, 2022

I tested this PR, but had issues. Found that symfony/http-kernel has to also be bumped to ^6.0

@jasonmccreary
Copy link

@joecampo, yeah, that was our bad. Shift didn't account for Symfony dependencies. It will in the future.

@joecampo
Copy link
Contributor

joecampo commented Feb 8, 2022

@jasonmccreary That's awesome, thanks for all you do! Shift is such an awesome product :)

@mpociot mpociot closed this Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants