Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update salmon v1.9.0 #1266

Merged
merged 11 commits into from
Dec 1, 2022
Merged

Update salmon v1.9.0 #1266

merged 11 commits into from
Dec 1, 2022

Conversation

gallardoalba
Copy link
Contributor

@gallardoalba gallardoalba commented Nov 20, 2022

This PR updates salmon. In addition it improves index generation by enabling decoy-aware transcriptome, according with https://salmon.readthedocs.io/en/latest/salmon.html#preparing-transcriptome-indices-mapping-based-mode

@gallardoalba
Copy link
Contributor Author

Not sure why it is failing, I didn't modify the .shed.xml file @bgruening

@bgruening
Copy link
Owner

I see a broken XML in alevin. Planemo lint will show you.

@gallardoalba
Copy link
Contributor Author

I see a broken XML in alevin. Planemo lint will show you.

Ah, thanks a lot!

@gallardoalba
Copy link
Contributor Author

Dot not merge, I need to fix an error.

@gallardoalba
Copy link
Contributor Author

Now should be fine.

@gallardoalba
Copy link
Contributor Author

gallardoalba commented Nov 23, 2022

This is the current error, but it is strange because also the non-modified XML file seems to fail:

Traceback (most recent call last): 
File "/home/laptop/Galaxy/galaxy/lib/galaxy/jobs/runners/__init__.py", line 629, in _finish_or_resubmit_job job_wrapper.finish( 
File "/home/laptop/Galaxy/galaxy/lib/galaxy/jobs/__init__.py", line 1853, in finish self._finish_dataset(output_name, dataset, job, context, final_job_state, remote_metadata_directory) File "/home/laptop/Galaxy/galaxy/lib/galaxy/jobs/__init__.py", line 1671, in _finish_dataset dataset.datatype.set_meta(dataset, overwrite=False) 
File "/home/laptop/Galaxy/galaxy/lib/galaxy/datatypes/tabular.py", line 1613, in set_meta for line in dataset_fh: File "/home/laptop/miniconda3/envs/_galaxy_/lib/python3.8/codecs.py", line 322, in decode (result, consumed) = self._buffer_decode(data, self.errors, final) UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 1: invalid start byte

@gallardoalba
Copy link
Contributor Author

This is the error: Timed out after 900.25 seconds waiting on tool test run, but I don't think is a tool problem @bgruening

@bgruening
Copy link
Owner

It could mean that Galaxy has been waiting for conda for too long and that the dependencies are conflicting ... I restarted lets see..

@gallardoalba
Copy link
Contributor Author

It could mean that Galaxy has been waiting for conda for too long and that the dependencies are conflicting ... I restarted lets see..

It seems to be fixed. I read that Alevin will be replaced very soon by Alevin-fry very soon.

@bgruening
Copy link
Owner

Ist alevin fry the single cell component?

@bgruening bgruening merged commit 866b22f into bgruening:master Dec 1, 2022
@gallardoalba
Copy link
Contributor Author

Ist alevin fry the single cell component?

Yes, according the developers, despite Alevin will be maintained for a while, it will be replaced by Alevin-fry.

@gallardoalba gallardoalba deleted the Update_salmon branch December 1, 2022 21:59
@bgruening
Copy link
Owner

Ok good to know. Maybe we can replace this tool here at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants