Skip to content

v1.2.0

  • v1.2.0
  • 4e3b1d3

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode

  • Choose a tag to compare

    View all tags
v1.2.0: fix(ci): remove branch name requirement for PRs (#48)
  • v1.2.0
  • 4e3b1d3

  • Choose a tag to compare

    View all tags

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
@bhouston bhouston tagged this 18 Sep 19:30 
## Summary
- Removed the CI/`scripts/check-pr.mjs` check that rejected PR branches
not matching `(feature|fix|chore|docs|refactor|test)/<issue>-<slug>`.
- The check now only verifies the PR targets `main` and its body
references the closing issue (`Closes #N` etc.), without deriving the
issue number from the branch name.
- Updated CONTRIBUTING.md to state branch names aren't checked.
- Updated the corresponding unit test in `scripts/release.test.mjs`.

Closes #47

## Test plan
- [x] `node --test scripts/release.test.mjs` passes locally
- [x] CI (`Validate issue link`, lint, tests) runs on this PR
Assets 2
Loading