Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pvviewer to work with jupyter notebook #116

Merged
merged 1 commit into from
Aug 22, 2015
Merged

create pvviewer to work with jupyter notebook #116

merged 1 commit into from
Aug 22, 2015

Conversation

aebrahim
Copy link
Contributor

This allows easy viewing of PDB structures within the ipython/jupyter notebook interface.

image

biasmv added a commit that referenced this pull request Aug 22, 2015
create pvviewer to work with jupyter notebook
@biasmv biasmv merged commit 7baeaa7 into biasmv:master Aug 22, 2015
@biasmv
Copy link
Owner

biasmv commented Aug 22, 2015

Hi,

thanks for this. I've merged your PR into master. Having better support for ipython (aehm jupyter) notebooks has been on my todo list for a while but I have never found the time to implement a python wrapper so far.

How are you currently using this? Are you also doing structure analysis in the jupyter notebooks and are just using PV to display structures on the side? In that case, it would make sense to also provide functionality in python to display local structure files, and allow to tweak the coloring as well as the display of it through properties.

Best,
Marco

@aebrahim aebrahim deleted the pvviewer branch August 22, 2015 09:51
@aebrahim
Copy link
Contributor Author

I'm glad to hear this was useful!

This was actually mainly a proof-of-concept I made for my colleague @ebrunk to demonstrate that this is possible... I agree that adding local files (trivial to add) and the ability to tweak the display style would make this useful to even more people. I think that can be done pretty easily by mirroring the properties which can be set by PV in the PDBViewer class and having the javascript render function apply those.

I'm sure @ebrunk has lots of ideas for other features as well.

@aebrahim
Copy link
Contributor Author

Also may I suggest you claim the pvviewer package name on pypi.python.org (or whatever name you feel you want the python package to be installed as)

@biasmv
Copy link
Owner

biasmv commented Aug 24, 2015

Hi,

I guess that depends: if you feel like taking this further yourself, it probably makes more sense for you to claim the package on pypi.python.org and be listed as the main author :).

Best,
Marco

@aebrahim
Copy link
Contributor Author

Well in any case I made the package. If have (or want to make) a pypi account, I can add it to the "administrator" list.

https://pypi.python.org/pypi/pvviewer

@biasmv
Copy link
Owner

biasmv commented Aug 25, 2015

Thanks!

@aebrahim
Copy link
Contributor Author

Hello,

It looks like you've improved this even more! I really don't think I'll have time to take this any further, however.

If you want the pvviewer package name I can give it to you if you give me your pypi username.

https://pypi.python.org/pypi/pvviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants